Review Request: Be more conservative about emitting dataUpdated() signal

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/147/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This prevents Plasma::DataContainer::setData() from setting the dirty flag if it did not actually change anything.

This ensures that dataUpdated() is not emitted if the data was not actually updated.

The question is: is this behaviour we want?  I can see that some applets (such as ones that draw graphs for system or network usage) might want to depend on getting dataUpdated() regularly, even if the data is exactly the same as before.


Diffs
-----

  trunk/KDE/kdebase/workspace/libs/plasma/datacontainer.cpp

Diff: http://reviewboard.vidsolbach.de/r/147/diff


Testing
-------

Compiles.  Applets still get updates.


Thanks,

Alex