network dataengine in kdereview

[Gerhard Gappmeier]

Hi Aaron,

I just took a quick look at the code.

If noticed that readNumberFromFile() and readStringFromFile() are using
fopen to access the file.
1.) For passing the filename as character string, it uses
QString::toLatin1()
This will not work if the filename has any special characters that don't
fit into the local character set.
QString::toLocal8Bit() would do that job.

2.) Why using fopen at all? I think using QFile would be more consistent
to the rest of the Qt code.
But this would be more cosmetic change, becasue fopen should be portable
too.

regards,
Gerhard Gappmeier

Aaron J. Seigo schrieb:
> hi...
>
> i just finished porting the network DataEngine that was in playground to the 
> current Solid APIs. everything seems to work and i'd like to see this 
> functionality in 4.2, so i've moved it to kdereview into 
> plasma/dataengines/network/.
>
> please review, comment, etc.
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20080825/2d6254e1/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 257 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080825/2d6254e1/attachment.sig