<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-15"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Aaron,<br>
<br>
I just took a quick look at the code.<br>
<br>
If noticed that readNumberFromFile() and readStringFromFile() are using
fopen to access the file.<br>
1.) For passing the filename as character string, it uses
QString::toLatin1()<br>
This will not work if the filename has any special characters that
don't fit into the local character set.<br>
QString::toLocal8Bit() would do that job.<br>
<br>
2.) Why using fopen at all? I think using QFile would be more
consistent to the rest of the Qt code.<br>
But this would be more cosmetic change, becasue fopen should be
portable too.<br>
<br>
regards,<br>
Gerhard Gappmeier<br>
<br>
Aaron J. Seigo schrieb:
<blockquote cite="mid:200808241805.36188.aseigo@kde.org" type="cite">
<pre wrap="">hi...
i just finished porting the network DataEngine that was in playground to the
current Solid APIs. everything seems to work and i'd like to see this
functionality in 4.2, so i've moved it to kdereview into
plasma/dataengines/network/.
please review, comment, etc.
</pre>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
Plasma-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/plasma-devel">https://mail.kde.org/mailman/listinfo/plasma-devel</a>
</pre>
</blockquote>
</body>
</html>