System tray rewrite ready for review

Aaron J. Seigo aseigo at kde.org
Tue Aug 19 18:56:46 CEST 2008


On Monday 18 August 2008, Jason Stubbs wrote:
> Replying to myself...
>
> Jason Stubbs wrote:
> > Sebastian Kügler wrote:
> >> Positioning and background seem to be messed up here. See the
> >> screenshot.
> >
> > I've reproduced the positioning issue (it depends on the theme) so will
> > work on a fix for that,
>
> There's actually two issues. I introduced a bug when rewriting some code
> to make it easier to read (now fixed) and a corner case when the size of
> two rows lies between the size of the content area with and without the
> background. Will continue to work on the latter.

does this mean it is ready for review again or that more work is needed first? 
when you feel it is ready for review, please move it into kdereview and i'll 
take a look at it then.

> >> Also, when I removed the old systray, and put the new one into its
> >> place, the icons wouldn't show up.
> >>
> >> restarting plasma made it show up in the top left corner, logging out
> >> and in again gave me the screenshot results.
>
> Nothing further news on these two at this stage other than I can't see
> anything that might be responsible in the code...

is this fix for you, Sebas, in current svn?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080819/70be8869/attachment.sig 


More information about the Plasma-devel mailing list