Review Request: New Kickoff Context Menu Action: "Start Application on Login"

[Alex Merry]

> On None, Aaron Seigo wrote:
> > I'm cool with this; please commit. However, it would be really nice if you could continue to work on this. It's really not a *huge* amount of work and would change this from "cool hack" to "solid feature" =)
> 
> Conor Sullivan wrote:
>     I don't have a svn account yet... I guess I start the application process in the next couple of days since I'm actively contributing.  Also, I'll try to learn the kde style conventions, since apparently Allman style isn't appropriate here! :D
>     
>     Also, I'll keep thinking about expanding it to be more complete.

Any news on this?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/47/#review38
-----------------------------------------------------------


On None, Conor Sullivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/47/
> -----------------------------------------------------------
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds a context menu action on kickoff to have an application start on startup.  This line is the key line:
> +	    KIO::copy(url, KGlobalSettings::autostartPath() );
> 
> This feature could in the future be expanded to detect when a program is already started on login, and then change to "Don't start application on startup".  This is significantly more complicated.
> 
> It would not be difficult (and I think a good idea) to add a similar patch to the "properties dialog" for .desktop files.  The user could click a button and have that program start on login.
> 
> Edit: so I've been asked to elaborate on my future ideas.  I'm sorry if I'm not very clear.
> Basically, if you have a application that already starts on login, its a bit silly to have a context menu to that offers to start it on login.  To fix these, we need to write code that searches for the application in the major autostart directories, .kde4/autostart, .kde4/share/autostart, xdg autostart, and possibly others.  Then we would need to find a way to compare the .desktop files and detect a match.  
> 
> If a match is found, we change the action to be "Don't start this application on login".
> 
> I also mentioned a possible addition to the properties dialog for .desktop files.  If would could implement the above, we could create a check box that says "Start on login"... you check the box, and the file is copied to .kde4/autostart... you uncheck the box, and that file is removed.  
> 
> I'm not promising to do all this, its just speculative.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/contextmenufactory.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/47/diff
> 
> 
> Testing
> -------
> 
> Compiles and seems to work here.
> 
> 
> Thanks,
> 
> Conor
> 
>