Wallpaper class; API review requested

[Aaron J. Seigo]

On Wednesday 13 August 2008, Petri Damstén wrote:
> - Should wallpaper plugin rely on that parent in
> createConfigurationInterface has applyClicked() and okClicked() signals
> like applets do?

yes, i think so.

> - Should the wallpaper plugin configuration be containment specific (I
> think yes. Would be nice to be able to have different background on
> different screens.)? If yes plugin needs a way to get containment config
> group where to save it's config.

yes, the wallpaper will need to know which containment it is associated with 
and then do something like:

KConfigGroup Wallpaper::config()
{
	KConfigGroup c = d->containment->config();
	return KConfigGroup(&c, "Wallpaper");
}

alternately, a load and save method set could be added that take a 
KConfigGroup& and call that from the appropriate places in the config dialog 
and/or containment. i actually like that better as it means that it keeps the 
coupling loose between Containment and Wallpaper and even opens up crazy 
things like letting one Wallpaper render into multiple Containments.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080813/9ea8d1a3/attachment.pgp