Wallpaper class; API review requested

[Aaron J. Seigo]

On Wednesday 13 August 2008, Kevin Ottens wrote:
> Le Wednesday 13 August 2008, Aaron J. Seigo a écrit :
> > On Wednesday 13 August 2008, Kevin Ottens wrote:
> > > Le Tuesday 12 August 2008, Aaron J. Seigo a écrit :
> > > > ownership of the Wallpaper* would then be taken by the Containment in
> > > > this case;
> > >
> > > Is that required?
> >
> > no; but then it's another connect-to-destroyed(QObject*) bit of code.
>
> I think this solution would still have my preference over the current one.

other than to provide for symmetry in the API, i don't see the point nor the 
purpose of this. can you give me a real world use case for this?

right now it just looks like API OCD to me, and i really dislike the 
destroyed(QObject*) code path when it's not needed.

the point that might be missing here is that the wallpaper plugin is internal 
to the containment. it's not meant to be some external item. it's simple 
something that can be defined by external users of containment ("please use 
wallpaper foo in render mode bar").

i think the current API communicates this rather nicely, actually.


-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20080813/887388cb/attachment.pgp