Review Request: add the button color to Plasma::Theme

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/123/#review108
-----------------------------------------------------------

Ship it!


> would make sense to support other colorsets too, like > view and tooltip?

yes. we just need use cases for them (just like you found with button and tabbar =)


- Aaron


On 2008-08-04 12:21:25, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/123/
> -----------------------------------------------------------
> 
> (Updated 2008-08-04 12:21:25)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this adds button text and button background color roles for the plasma theme and uses it in the proper widgets (button and tabbar for now)
> 
> on a related note, would make sense to support other colorsets too, like view and tooltip?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/private/nativetabbar.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/pushbutton.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/123/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>