Review Request: Check bundle for vlc library before system libraries on OS X
Leo Franchi
lfranchi at kde.org
Wed Mar 7 23:12:51 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104154/
-----------------------------------------------------------
(Updated March 7, 2012, 11:12 p.m.)
Review request for Phonon Backends and Harald Sitter.
Description
-------
On OS X, check bundle for VLC *before* checking system paths. Otherwise, if this phonon-vlc is running from a self-sufficient bundle, and the user has a vlc installed in system paths (/usr/local/ from homebrew, for example) this will ignore the bundle copy and access the system one.
This can often lead to crashes as the system copy might be built with a different compiler, link to duplicated libraries, etc.
Diffs (updated)
-----
src/utils/libvlc.cpp 44f07db
Diff: http://git.reviewboard.kde.org/r/104154/diff/
Testing
-------
Thanks,
Leo Franchi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20120307/de162f65/attachment.html>
More information about the Phonon-backends
mailing list