Review Request: Check bundle for vlc library before system libraries on OS X

[Leo Franchi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104154/
-----------------------------------------------------------

Review request for Phonon Backends and Harald Sitter.


Description
-------

On OS X, check bundle for VLC *before* checking system paths. Otherwise, if this phonon-vlc is running from a self-sufficient bundle, and the user has a vlc installed in system paths (/usr/local/ from homebrew, for example) this will ignore the bundle copy and access the system one.

This can often lead to crashes as the system copy might be built with a different compiler, link to duplicated libraries, etc.


Diffs
-----

  src/utils/libvlc.cpp 44f07db 

Diff: http://git.reviewboard.kde.org/r/104154/diff/


Testing
-------


Thanks,

Leo Franchi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20120304/be78726f/attachment.html>