Review Request: Check bundle for vlc library before system libraries on OS X
Harald Sitter
sitter at kde.org
Wed Mar 7 22:58:45 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104154/#review11217
-----------------------------------------------------------
Ship it!
src/utils/libvlc.cpp
<http://git.reviewboard.kde.org/r/104154/#comment9021>
Friends! What's with the whitespaces already?
- Harald Sitter
On March 4, 2012, 10:05 p.m., Leo Franchi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104154/
> -----------------------------------------------------------
>
> (Updated March 4, 2012, 10:05 p.m.)
>
>
> Review request for Phonon Backends and Harald Sitter.
>
>
> Description
> -------
>
> On OS X, check bundle for VLC *before* checking system paths. Otherwise, if this phonon-vlc is running from a self-sufficient bundle, and the user has a vlc installed in system paths (/usr/local/ from homebrew, for example) this will ignore the bundle copy and access the system one.
>
> This can often lead to crashes as the system copy might be built with a different compiler, link to duplicated libraries, etc.
>
>
> Diffs
> -----
>
> src/utils/libvlc.cpp 44f07db
>
> Diff: http://git.reviewboard.kde.org/r/104154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Leo Franchi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20120307/ae5f1704/attachment.html>
More information about the Phonon-backends
mailing list