Review Request: Fix StreamReader

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100471/#review1138
-----------------------------------------------------------


No good as it breaks KIO streaming. The ultimate solution is to make our abstractstream implementation thread between a backend's streamreader and the actual abstractstream implementation, so that the backend *always* interacts with a threaded system and can act accordingly (with waitconditions and what not). The m_size change however seems perfectly fine.

- Harald


On Jan. 31, 2011, 3:36 p.m., Kamil Klimek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100471/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2011, 3:36 p.m.)
> 
> 
> Review request for Phonon Backends.
> 
> 
> Summary
> -------
> 
> This patch makes StreamReader work properly for the moment. It removes a DeadLock (not sure about that one) and stops reseting stream size.
> 
> 
> Diffs
> -----
> 
>   vlc/streamreader.cpp 06c9068 
> 
> Diff: http://git.reviewboard.kde.org/r/100471/diff
> 
> 
> Testing
> -------
> 
> I'm able to seek streams, and play streams (QIODevice)
> 
> 
> Thanks,
> 
> Kamil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/phonon-backends/attachments/20110201/bc3ed307/attachment.htm