Review Request: Fix StreamReader

Kamil Klimek naresh at tlen.pl
Tue Feb 1 08:49:05 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100471/#review1137
-----------------------------------------------------------

Ship it!


Fixes QIODevice playing, so why not? Streaming needs bigger work to fix/cleanup, but atm it's unusable

- Kamil


On Jan. 31, 2011, 3:36 p.m., Kamil Klimek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100471/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2011, 3:36 p.m.)
> 
> 
> Review request for Phonon Backends.
> 
> 
> Summary
> -------
> 
> This patch makes StreamReader work properly for the moment. It removes a DeadLock (not sure about that one) and stops reseting stream size.
> 
> 
> Diffs
> -----
> 
>   vlc/streamreader.cpp 06c9068 
> 
> Diff: http://git.reviewboard.kde.org/r/100471/diff
> 
> 
> Testing
> -------
> 
> I'm able to seek streams, and play streams (QIODevice)
> 
> 
> Thanks,
> 
> Kamil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/phonon-backends/attachments/20110201/a5735137/attachment.htm 


More information about the Phonon-backends mailing list