Review Request: fix setCurrentSubtitle index problem

[Sian Cao]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102191/
-----------------------------------------------------------

(Updated Aug. 4, 2011, 6:46 a.m.)


Review request for Phonon Backends.


Changes
-------

version 3
the way GlobalDescriptionContainer::add gets next free id is wrong, this patch fix that too.


Summary
-------

the problem lies in setCurrentSubtitle, if called with the same subtitle which has type 'file', assertion in GlobalSubtitles::add will fail because if identical index. 


Diffs (updated)
-----

  src/globaldescriptioncontainer.h 3ba4e06 
  src/mediacontroller.cpp 3aa7b96 

Diff: http://git.reviewboard.kde.org/r/102191/diff


Testing
-------


Thanks,

Sian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110804/4c85bb93/attachment.html>