Review Request: fix setCurrentSubtitle index problem

[Sian Cao]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102191/
-----------------------------------------------------------

(Updated Aug. 4, 2011, 5:01 a.m.)


Review request for Phonon Backends.


Changes
-------

another version of fix, which may be better.
after all only GlobalSubtitles knows all the global ids, so there is no way for setCurrentSubtitle to add an external subtitle with global id.


Summary
-------

the problem lies in setCurrentSubtitle, if called with the same subtitle which has type 'file', assertion in GlobalSubtitles::add will fail because if identical index. 


Diffs (updated)
-----

  src/mediacontroller.cpp 3aa7b96 

Diff: http://git.reviewboard.kde.org/r/102191/diff


Testing
-------


Thanks,

Sian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110804/5be9390d/attachment.html>