about a patch

thierry.bastian at nokia.com thierry.bastian at nokia.com
Mon Nov 24 09:54:56 CET 2008


Hi Matthias,

I just saw that you reverted a patch we submitted last week, namely this:

@@ -422,6 +422,7 @@ void MediaObjectPrivate::_k_aboutToFinish()
     if (sourceQueue.isEmpty()) {
         emit q->aboutToFinish();
         if (sourceQueue.isEmpty()) {
+            pINTERFACE_CALL(setNextSource(MediaSource()));
             return;
         }
     }

I was wondering why...
The idea behind removing that is that one can call setMediaSource(MediaSource()) and it will unload the current source.
To make it consistent with the way queuing works you could imagine enqueuing an invalid mediaSource to unload the last source when it is finished playing.
On the backend side we then need to know if the user/programmer explicitly has queued an invalid media source.
Applying this patch makes that this information is no more available. Plus I wonder why it should do that. Any specific reason for it? Our backends don't need that.

Thanks for any insight.

Regards,
Thierry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/phonon-backends/attachments/20081124/4802dee0/attachment.htm 


More information about the Phonon-backends mailing list