[Patch] Phonon: add 2 methods to Path

Tanguy Krotoff tkrotoff at gmail.com
Thu Nov 20 21:47:29 CET 2008


No pb, I know that you are pretty busy these days.
Same for me, reason: I'm looking for a new job (not in CS, and it's
pretty hard these days...)

I will need a bit more of your help in the future for a (bigger) patch
(we have already discuss about it) since I have difficulties to keep
Phonon binary compatibility.

Lukas Durfina now maintains the VLC backend and he has integrated
several patches inside libvlc to make it works fine. For now (I might
be wrong) the VLC backend requires VLC 1.0 svn so it should be fully
functional when VLC 1.0 is ready.
For the MPlayer backend, I've just started to use it everyday for my
music and video playback under Windows.
Ian Monroe suggested me to commit it to the KDE playground.

I know I'm pretty slow :/

Anyway, thx for coding on Phonon, it's a very beautiful library that I
enjoy a lot!

On Thu, Nov 20, 2008 at 2:57 PM, Matthias Kretz <kretz at kde.org> wrote:
> Hi Tanguy,
>
> thanks for your patch. Thierry thought of you again and your patch finally got
> committed to phonon trunk.
>
> Sorry for letting you wait so long.
>
>        Matthias
>
> On Wednesday 17 September 2008 15:17:21 Tanguy Krotoff wrote:
>> Hello again
>>
>> Here is a very small patch that adds 2 methods to Phonon::Path:
>> MediaNode *Path::sourceNode() const
>> MediaNode *Path::sinkNode() const
>>
>> This is useful when manipulating several MediaObject/AudioOutput/...,
>> then you don't need to keep track of everything yourself, Path does it
>> for you:
>>
>>       Phonon::MediaObject * mediaObject = new Phonon::MediaObject(this);
>>
>>       QList<Phonon::Path> outputPaths = mediaObject->outputPaths();
>>       foreach (Phonon::Path outputPath, outputPaths) {
>>               Phonon::AudioOutput * audioOutput = dynamic_cast<Phonon::AudioOutput
>> *>(outputPath.sinkNode());
>>               if (audioOutput) {
>>                       //blabla
>>               }
>>       }
>>
>> I don't really understand why this 2 methods where not already there.
>>
>> So if someone could simply tell me if it is OK or not...
>>
>> Thanks in advance

-- 
Tanguy Krotoff <tkrotoff at gmail.com>
+33 6 68 42 70 24


More information about the Phonon-backends mailing list