Video effects

[Thierry Bastian]

The problem is still the same: we can't easily have a common base of
effects. So adding a GaussianBlurEffect class would not make sense out of
the Quicktime world.

Thinking loud: Maybe a factory could do that job?

Thierry

-----Original Message-----
From: Matthias Kretz [mailto:kretz at kde.org] 
Sent: vendredi 13 juillet 2007 13:23
To: phonon-backends at kde.org
Subject: Re: Video effects

On Friday 13 July 2007, Richard wrote:
> What I would prefer is something more like this:
> ---
>      if (Backendcapabilies::hasVideoEffect(Effect::GaussianBlur))
>      	Effect * e = new Effect(Effect::GaussianBlur, parent);
>
> or alternatively:
>
>      Effect * e = new Effect(Effect::GaussianBlur, parent);
>      if (e->isValid()){
>          ...
>      }
> ---

Why not go the whole way and provide
GaussianBlurEffect *e = new GaussianBlurEffect(parent); if (e->isValid()) {
    ...
}
then? Because otherwise you still have no guarantees about the parameters.

The generic Effect class was meant to be used by user interaction only. If
an app needs to integrate an effect then it needs a specialized interface to
that effect.

This, of course, will blow up the lib size again so perhaps this should be
in a second library or #ifdefed as a feature?

--
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de