Video effects

[Matthias Kretz]

On Friday 13 July 2007, Richard wrote:
> What I would prefer is something more like this:
> ---
>      if (Backendcapabilies::hasVideoEffect(Effect::GaussianBlur))
>      	Effect * e = new Effect(Effect::GaussianBlur, parent);
>
> or alternatively:
>
>      Effect * e = new Effect(Effect::GaussianBlur, parent);
>      if (e->isValid()){
>          ...
>      }
> ---

Why not go the whole way and provide
GaussianBlurEffect *e = new GaussianBlurEffect(parent);
if (e->isValid()) {
    ...
}
then? Because otherwise you still have no guarantees about the parameters.

The generic Effect class was meant to be used by user interaction only. If an 
app needs to integrate an effect then it needs a specialized interface to 
that effect.

This, of course, will blow up the lib size again so perhaps this should be in 
a second library or #ifdefed as a feature?

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/phonon-backends/attachments/20070713/bb63835f/attachment.pgp