Emailing: objectdescriptionmodel.patch

[Thierry Bastian]

Well that was the test that I was supposed to send you on Wednesday. I don't
know why it was only sent on Friday...

Anyway, this still boils down to the question: do we do a
libphononutilities? If yes then ObjectDescriptionModel clearly has its place
there.
And then exporting the factory::icon function even if it's a private header
is not a problem.

If Håvard finds a huge difference in size then we may simply have to split.
Let's wait and see.

During the meeting last week a small suggestion: why not call VideoPlayer
SimpleVideoPlayer (same thing for audio). The thing is that people might
expect a lot from those widgets and I don't think we want people to file
thousands of requests for it to have the same feature-set as a complete
media player.

Regards,
Thierry
 
-----Original Message-----
From: Matthias Kretz [mailto:kretz at kde.org] 
Sent: dimanche 1 juillet 2007 12:10
To: Thierry Bastian
Cc: phonon-backends at kde.org
Subject: Re: Emailing: objectdescriptionmodel.patch

On Friday 29 June 2007, Thierry Bastian wrote:
> And here's the patch.

You've disabled the QMetaObject calls for qobject_cast. How about a
compromise and keep the 13 staticMetaObject symbols in libphonon, in
addition to the ObjectDescriptionModelData::data function which needs to
access factory.h (that's a private header, probably should be renamed to
factory_p.h then). 
This would result in 4352 bytes in libphonon, of which 64 bytes come from
ObjectDescriptionModelData::data.

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de