Getting ds9 backend working with kde

[Thierry Bastian]

Hi Shane,

Right, I had missed the difference here. So adding the constructor with no
default argument sound the most sensible thing to do then.

Thierry

-----Original Message-----
From: Shane King [mailto:kde at dontletsstart.com] 
Sent: vendredi 14 décembre 2007 09:27
To: Thierry Bastian
Cc: phonon-backends at kde.org
Subject: Re: Getting ds9 backend working with kde

Thierry Bastian wrote:
> Hi Shane,
> 
> Nice to hear that the ds9 plugin will be used in Amarok.
> For the export of the plugin, you could use the
PHONON_MAKE_QT_ONLY_BACKEND
> define. It is defined when building with Qt (comes from the .pro file).
You
> could probably do that directly in the backend.cpp. I don't see the real
> need for an additional file here (ie kde.cpp).
> About the constructor, I don't see what it brings except that some
compilers
> might complain that it is ambiguous. Why do you want to change that?
> 
> Thierry

I need the extra constructor because KPluginFactory expects the second 
argument to be a QVariantList. Without it I get

C:\unix\msvc\include\kpluginfactory.h(459) : error C2664: 
'Phonon::DS9::Backend::Backend(QObject *,const QStringList &)' : cannot 
convert parameter 2 from 'const QVariantList' to 'const QStringList &'
         Reason: cannot convert from 'const QVariantList' to 'const 
QStringList'
         No user-defined-conversion operator available that can perform 
this conversion, or the operator cannot be called
         C:\unix\msvc\include\kpluginfactory.h(477) : see reference to 
function template instantiation 'QObject 
*KPluginFactory::createInstance<impl,QObject>(QWidget *,QObject *,const 
QVariantList &)' being compiled
         with
         [
             impl=Phonon::DS9::Backend
         ]
         C:\unix\msvc\include\kpluginfactory.h(477) : while compiling 
class template member function 'KPluginFactory::CreateInstanceFunction 
KPluginFactory::InheritanceChecker<impl>::createInstanceFunction(...)'
         with
         [
             impl=Phonon::DS9::Backend
         ]
         C:\unix\msvc\include\kpluginfactory.h(389) : see reference to 
class template instantiation 'KPluginFactory::InheritanceChecker<impl>' 
being compiled
         with
         [
             impl=Phonon::DS9::Backend
         ]

I can change it to not have any default args and there should be no 
ambiguity.

Shane.