patch for Containment config

Aaron J. Seigo aseigo at kde.org
Wed May 21 19:02:57 CEST 2008


hi..

(not using review board because it seems to be, once again, fubar)

the attached patch does three things:

* switches use from KConfigGroup* to KConfigGroup&

* consolidates save/load/restore in Applet and Containment into one set of 
virtual methods (as well as settle on restore instead of load everywhere)

* introduces Containment::saveContents and restoreContents

the point of this (besides the API cleanliness) is to allow Containments to 
have fine grained control of their save/restore process. this will allow 
runtime containments that do not get saved as part of the layout, for example 
(needed by the notification applet) as well open the doors for containments 
that just don't follow the usual Applet pattern.

this is really a flaw in the API design, requires a BIC change and thus i 
consider it a bug fix.

for the existing codebase it is life as usual; this simply opens new doors 
where they are needed. please review and comment; i'd like to commit soon.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flexible_containment_save_restore.diff
Type: text/x-diff
Size: 12665 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080521/5029da10/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080521/5029da10/attachment.pgp 


More information about the Panel-devel mailing list