[PATCH] Config Dialog for Runners
Ryan P. Bitanga
ryan.bitanga at gmail.com
Sun May 18 09:46:38 CEST 2008
Hi,
Sorry for keeping you waiting (yes, I read the commit logs). Got
buried with work.
Anyway, attached is a preliminary patch to support a config dialog for KRunner.
What's missing:
* Proper size hint for the dialog box
* Check box to load all runners instead of using the selector (should
disable the selector)
* General tab for settings in KRunnerSettings
CHANGES:
AbstractRunner:
- Get rid of all the configuration widget functions. Create a KCModule
instead and set the parent component in the desktop file to the runner
name.
- Add a reloadConfiguration method for runners who have their settings
changed via the config dialog (e.g. the spellcheck runner)
RunnerManager:
- Switch to a QHash so it's easier to remove unneeded runners.
- Fix the load function.
Interface:
- Add an ugly configure button. (Somebody think of a better solution
like a configure button in the upper right corner or something)
NEXT STEPS:
1. Address items listed in the what's missing section above
2. Remove runner phase from the desktop files and place appropriate
priorities in the constructors of the runners.
3. Enable runners in plasma/runners by default. (Add the
X-KDE-PluginInfo-EnabledByDefault=true lines to their desktop files)
Cheers,
Ryan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configdialog.diff.bz2
Type: application/x-bzip2
Size: 5019 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080518/6b8f4c18/attachment.bz2
More information about the Panel-devel
mailing list