Review Request: Build engineexplorer even if Soprano isn't found

Alex Merry huntedhacker at tiscali.co.uk
Sat May 3 16:29:40 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info:8080/r/356/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

At the moment, engineexplorer will not be built if Soprano isn't found.  Since it's quite a vital tool for Plasma development, this patch makes it build, but just without Soprano::Node support.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/tools/CMakeLists.txt
  trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/CMakeLists.txt
  trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.cpp

Diff: http://mattr.info:8080/r/356/diff


Testing
-------

Builds with the CMake variable WITH_Soprano set to OFF as well as ON.

#warnings used to check that the expected code was compiled in or out depending on the above variable.


Thanks,

Alex



More information about the Panel-devel mailing list