[PATCH] fix plasma and Qt monitor-hotplug issues

Aaron J. Seigo aseigo at kde.org
Mon Mar 31 17:01:56 CEST 2008


On Monday 31 March 2008, Aike J Sommer wrote:
> > yes, this part looks good. pls commit.
>
> Hmm... Dont have a svn-account... Should i apply for one that "early"??

i'll commit this patch for you, but if you'd like to continue working on 
things (i hope you do =) then it's probably a good idea to grab an account so 
you can take care of committing your own stuff, yes =)

> > iterating over the screens isn't a very expensive set of operations
> > (looping with an int, looping through our collection of containments)
> > that is only done at startup and when the screen counts change. it
> > ensures that it works no matter what happens elsewhere and makes the
> > method more self contained (e.g. it's obvious on reading it that it works
> > and what it does without having to read the rest of the code in the
> > class), so the cost is well worth it imho.
>
> Changed that part... Hope its okay now?!?! :-)

looks good =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080331/7440c6a8/attachment.pgp 


More information about the Panel-devel mailing list