[PATCH] the beginning of an 'add activity' action
Aaron J. Seigo
aseigo at kde.org
Sun Mar 23 22:42:05 CET 2008
On Sunday 23 March 2008, Chani wrote:
> On March 23, 2008 13:56:54 Aaron J. Seigo wrote:
> > that's the end goal for the current "Configure Desktop" dialog actually.
> > switching "wallpapers" will also involve changing the Containment if
> > necessary.
>
> o.0
> where's the line between configuring plasma and configuring the current
> containment's options?
the wallpaper is an attribute of the current containment.
> > > although... I should warn you guys, there's still a bug where applets'
> > > config is lost when they're reparented to another containment. this
> > > also applies to drag-to-panel. :( and you won't notice until you quit
> > > plasma.
> >
> > is the config group not getting reparented?
>
> the applet (in the config) itself is. the applet's config() (the child of
> what gets reparented, I guess?) isn't following. so you get an applet in
> the right place with default settings.
i imagine it's applet.cpp:478 where it deletes the group, which is now
recursive. didn't used to be, so that's probably why i got away with it
previously.
ok .. soooo ... i'll bet moving containment.cpp:627 to line 634 (the end of
the if statement) fixes it...
yep, seems to do the trick. committing now.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080323/2ad0a9fa/attachment.pgp
More information about the Panel-devel
mailing list