[PATCH] the beginning of an 'add activity' action

Chani chanika at gmail.com
Sun Mar 23 21:41:50 CET 2008


On March 22, 2008 23:40:18 Aaron J. Seigo wrote:
> On Saturday 22 March 2008, Chani wrote:
> > this patch adds a very very rough 'add activity' button to the toolbox.
> > it creates a new "desktop" containment. the containment positioning is a
> > little zany, but seems to return to sanity after plasma is restarted.
> > there's plenty of work still to be done here... just putting it out for
> > anyone interested.
>
> nice start ... this one:
>
>         //FIXME what sort of containment?
>
> is a good question. i think that this is the point where we should show a
> list of containments, much as we do with widgets right now.
>
> certainly this can happen after activity creation mechanics are working to
> our mutual satisfaction, but that'd be my suggestion for a completion of
> the feature.

perhaps. I was also thinking it might be cool to get the name of the 
containment the button was clicked in or something... maybe have a separate 
UI for selecting a specific containment, maybe provide a way to switch out 
the containment from under the applets, etc...


> of course, if the user clicks this in a Containment that we doesn't have a
> screen associated with it, then it doesn't work.
>
> that combined with the fact that the only place we know about zooming is in
> the View or in the paintInterface method of the Containment leads me to
> believe that this belonds in the View rather than in Containment itself.

yup.

>
> i'd also be more comfortable with naming the method something other than
> addActivity since that drags user interface terms into the code. we already
> have a consistent name for this in the code: Containment.
>
> so my proposal would be:
>
> * move Containment::addActivity() to DesktopView::addContainment()
>
> * add/remove the toolbox item in DesktopView in the zoomOut/zoomIn methods

yes, that's probably needed for "don't show when zoomed in" anyways.
hmmm. that does slightly hinder my idea of making hte containment match the 
one the button came from. maybe pass the signal through the containment like 
the way I changed zoomIn.

>
> it might be a good idea to corner ;) celeste on irc and talk a bit about
> the term "Add Activity". i like it, but it's so ... new. this is a new idea
> and term we're introducing into the desktop world here, so it probably
> can't hurt to have as many informed opinions on it as possible.

good idea.

>
> hm.. "Add Activity Area".. "New Activity Area" ... blurg.
>
> it's cool to see this idea finally taking shape though =)

:) I'm just happy I can finally expand my crowded desktop space ;)

although... I should warn you guys, there's still a bug where applets' config 
is lost when they're reparented to another containment. this also applies to 
drag-to-panel. :( and you won't notice until you quit plasma.

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080323/6897bbe3/attachment.pgp 


More information about the Panel-devel mailing list