[PATCH] the beginning of an 'add activity' action

[Aaron J. Seigo]

On Saturday 22 March 2008, Chani wrote:
> this patch adds a very very rough 'add activity' button to the toolbox. it
> creates a new "desktop" containment. the containment positioning is a
> little zany, but seems to return to sanity after plasma is restarted.
> there's plenty of work still to be done here... just putting it out for
> anyone interested.

nice start ... this one:

        //FIXME what sort of containment?

is a good question. i think that this is the point where we should show a list 
of containments, much as we do with widgets right now.

certainly this can happen after activity creation mechanics are working to our 
mutual satisfaction, but that'd be my suggestion for a completion of the 
feature.

these ones:

+        //FIXME if we're zoomed out (and we should be) the view needs to hook 
up signals
+        //FIXME maybe we should try to set the view's containment to this new 
one?

are good questions. it's probably safe to assume that if the user does 
successfully create a new activity area, that they want to focus on that. so 
post-creation, calling c->setScreen(screen()) should be enough to make the 
magic happen.

of course, if the user clicks this in a Containment that we doesn't have a 
screen associated with it, then it doesn't work.

that combined with the fact that the only place we know about zooming is in 
the View or in the paintInterface method of the Containment leads me to 
believe that this belonds in the View rather than in Containment itself.

i'd also be more comfortable with naming the method something other than 
addActivity since that drags user interface terms into the code. we already 
have a consistent name for this in the code: Containment.

so my proposal would be:

* move Containment::addActivity() to DesktopView::addContainment()

* add/remove the toolbox item in DesktopView in the zoomOut/zoomIn methods

it might be a good idea to corner ;) celeste on irc and talk a bit about the 
term "Add Activity". i like it, but it's so ... new. this is a new idea and 
term we're introducing into the desktop world here, so it probably can't hurt 
to have as many informed opinions on it as possible.

hm.. "Add Activity Area".. "New Activity Area" ... blurg.

it's cool to see this idea finally taking shape though =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080323/133f9332/attachment.pgp