Review Request: eject icons on devicenotifier

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/285/
-----------------------------------------------------------

(Updated 2008-03-14 15:51:25.947520)


Review request for Plasma.


Summary
-------

This patch adds a little eject icon to the right of mounted volumes in the device notifier. clicking on it ejects optical discs and unmounts other removable devices. additionally the devices icons now have the usual mounted overlays.

Reopened because i did forget to add an error message when is not possible to unmount.
now on optical disc eject failed the message is:
Failed to eject the disc.\nOne or more files on this disc are open within an application.
other discs are:
Failed to unmount the device.One or more files on this device are open within an application.

are they good as messages? (my english sucks :P)
still not sure if we can be sure the error is device busy btw...


This addresses bug 158936.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp

Diff: http://mattr.info/r/285/diff


Testing
-------

tried to unmount eject some dvds/thumbdrives.
tried also with the --reverse command line switch it puts the eject column on the left.


Screenshots
-----------

some discs mounted
  http://mattr.info/r/285/s/34/


Thanks,

Marco