Review Request: eject icons on devicenotifier

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/285/
-----------------------------------------------------------

(Updated 2008-03-14 13:49:25.697991)


Review request for Plasma.


Summary
-------

This patch adds a little eject icon to the right of mounted volumes in the device notifier. clicking on it ejects optical discs and unmounts other removable devices. additionally the devices icons now have the usual mounted overlays.

Reopened because i did forget to add an error message when is not possible to unmount.
this is a preliminary version that has two problems:
-the error message is the one returned by solid, absolutely not user friendly :) what could be done to replace it with more friendly strings? (errortype seems not to be useful so the error strings should be parsed in some way?) or can be assumed in this case the error is always device busy?
-the error dialog is displayed 3 times, why? :(


This addresses bug 158936.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp

Diff: http://mattr.info/r/285/diff


Testing
-------

tried to unmount eject some dvds/thumbdrives.
tried also with the --reverse command line switch it puts the eject column on the left.


Screenshots
-----------

some discs mounted
  http://mattr.info/r/285/s/34/


Thanks,

Marco