Review Request: fix aplet andle disappear

Marco Martin notmart at gmail.com
Fri Mar 14 12:39:52 CET 2008



> On 2008-03-13 11:45:16, Aaron Seigo wrote:
> > the patch looks fine, but perhaps we should just fix it properly by making the handles "window decorations" rather than make the existing code more complex.
> 
> Andrew Lake wrote:
>     Interesting... What might you have in mind when you say "window decorations"?  Do you mean the applet "window-decoration" handles would always show (with different button arrangement)?  I ask only because I started working on the applet handle appearance (aesthetics) last night and this might affect the result.
>     
>     (I apologize if this amounts to hijacking your review Marco.)
>

Andrew: no problem, i think the two things are related, because if this patch become useless probably every single modification to the applet handle code would have problems.
if i understood correctly now there is some standard qt class that would replace applet handles but digging in the qt documentation i didn't found anything.
aseigo:where i should search for window-decorations? oh, and about this patch, maybe won't have a long life on 4.1 but could it make sense to backport? (don't know if there is the handle disappear problem in 4.0.x)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/287/#review296
-----------------------------------------------------------


On 2008-03-12 13:30:23, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/287/
> -----------------------------------------------------------
> 
> (Updated 2008-03-12 13:30:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Well, probably the applet handle as is now won't survive for long, but this fixes the old 152797 that was once fixed and seems to be back to life...
> now the applet events are always filtered for a leaveevent and the disappear is done by another single shot timer.
> 
> 
> This addresses bug 152797.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/applethandle.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/applethandle_p.h
> 
> Diff: http://mattr.info/r/287/diff
> 
> 
> Testing
> -------
> 
> tested to move the mouse in various situations, also with overlapping applets or windows overlapping applets.
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Panel-devel mailing list