Review Request: fix aplet andle disappear

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/287/#review296
-----------------------------------------------------------


the patch looks fine, but perhaps we should just fix it properly by making the handles "window decorations" rather than make the existing code more complex.

- Aaron


On 2008-03-12 13:30:23, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/287/
> -----------------------------------------------------------
> 
> (Updated 2008-03-12 13:30:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Well, probably the applet handle as is now won't survive for long, but this fixes the old 152797 that was once fixed and seems to be back to life...
> now the applet events are always filtered for a leaveevent and the disappear is done by another single shot timer.
> 
> 
> This addresses bug 152797.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/applethandle.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/applethandle_p.h
> 
> Diff: http://mattr.info/r/287/diff
> 
> 
> Testing
> -------
> 
> tested to move the mouse in various situations, also with overlapping applets or windows overlapping applets.
> 
> 
> Thanks,
> 
> Marco
> 
>