Review Request: Containment placement strategy
Aaron Seigo
aseigo at kde.org
Thu Mar 13 18:33:39 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/296/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
This patch allows Containment subclasses to define the layout strategy based on form factor changes by reimplementing createLayout. while this could theoretically be done in constraintsUpdated, doing so would introduce possible race conditions between the containment setting up the layout and applets starting to adjust themselves. this also keeps constraintsUpdated a bit cleaner for Containments, but mostly it's about avoiding out-of-order processes.
Diffs
-----
/trunk/KDE/kdebase/workspace/libs/plasma/containment.h
/trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
Diff: http://mattr.info/r/296/diff
Testing
-------
Currently running Plasma with it.
Thanks,
Aaron
More information about the Panel-devel
mailing list