Review Request: Fix "double-click" behaviour of AppletBrowser

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/294/#review293
-----------------------------------------------------------

Ship it!


other than the use of magic numbers (not your fault, it already was like that) this patch looks good and fixes an annoying bug.

nice work =)



trunk/KDE/kdebase/workspace/libs/plasma/appletbrowser/kcategorizeditemsview.cpp
<http://mattr.info/r/294/#comment212>

    magic numbers suck. could we perhaps have an enum in here instead?


- Aaron


On 2008-03-13 11:05:12, Dmitry Suzdalev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/294/
> -----------------------------------------------------------
> 
> (Updated 2008-03-13 11:05:12)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch fixes appletbrowser's behaviour when double clicking on "favicon" or "remove" column would unexpectedly add a plasmoid to the desktop.
> My first plasma patch, so its quite trivial ;)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/appletbrowser/kcategorizeditemsview.cpp
>   trunk/KDE/kdebase/workspace/libs/plasma/appletbrowser/kcategorizeditemsview_p.h
> 
> Diff: http://mattr.info/r/294/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>