[PATCH] Bug 158444: Pager can't display name of desktop
Rafał Miłecki
zajec5 at gmail.com
Wed Mar 12 15:19:50 CET 2008
2008/3/12, Aaron J. Seigo <aseigo at kde.org>:
> On Wednesday 12 March 2008, Rafał Miłecki wrote:
> > I prepared patch for bug https://bugs.kde.org/show_bug.cgi?id=158444
> >
> > Could someone check it and apply if everything is fine?
>
>
> + int m_displayedText; // 0==desktop number ; 1==desktop name ; 2==none
>
> using an enumeration rather than an integer with magic values that have the be
> documented in this way would make it more readable and maintainable.
>
> otherwise, it looks ok, and once it can be applied cleanly to trunk/ and
> tested (as Jeremy noted) it'd be nice to have it in..
Thanks for comments! I'll change this m_displayedText and recreate
patch to be compatible with current SVN. Let me a little of time and
I'll resend this :)
--
Rafał Miłecki
More information about the Panel-devel
mailing list