[PATCH] Bug 158444: Pager can't display name of desktop

Aaron J. Seigo aseigo at kde.org
Wed Mar 12 14:30:09 CET 2008


On Wednesday 12 March 2008, Rafał Miłecki wrote:
> I prepared patch for bug https://bugs.kde.org/show_bug.cgi?id=158444
>
> Could someone check it and apply if everything is fine?

+       int m_displayedText; // 0==desktop number ; 1==desktop name ; 2==none

using an enumeration rather than an integer with magic values that have the be 
documented in this way would make it more readable and maintainable.

otherwise, it looks ok, and once it can be applied cleanly to trunk/ and 
tested (as Jeremy noted) it'd be nice to have it in..

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080312/7e12ed96/attachment.pgp 


More information about the Panel-devel mailing list