Review Request: Animates tabswitching

[Marco Martin]

> On 2008-03-10 10:00:07, Marco Martin wrote:
> > i think it looks good, both in code and visually
> 
> Will Stephenson wrote:
>     Can we hold off committing this?  I found it too slow, and frankly, redundant to have an animation here at all.
> 
> Mehdi Salem Naraghi wrote:
>     Well the speed of the animation can be increased but I must admit that it feels slower than the animation done using the QTimeLine. I did however use 150ms in both situations so its probably a Phase issue. It's just a perception though and I might be wrong.
> 
> Mehdi Salem Naraghi wrote:
>     Btw, I think the animation looks good and is not redundant at all.
> 
> Marco Martin wrote:
>     it has the same speed of the animation of the icon, so i don't think it somewhat collides with it, i think it looks pretty good.
>     maybe is the distance that the tab travel for instance if it goes from the first to the last? maybe a fade out of the old tab together a fade in of the new one would be less appariscent? (but maybe more complicate code because two tabs should be rendered at the same time)
> 
> Mehdi Salem Naraghi wrote:
>     Have to try out your suggestion tomorrow. Another solution would be to move the animation rect the other way round instead of travelling the direct way. That is to say, moving the tab out of the tabbar and entering it from the other side. It would definetly increase the complexity of the code but may look appealing. What do you think?
> 
> Mehdi Salem Naraghi wrote:
>     That's how it would behave like: http://www.informatik.uni-bremen.de/~momesana/out.ogv
>     With the previous look of course ;-). I would like to get some feedback about this. If you like it to have that circular movement I can go on and implement it (it's actually mostly implemented as you can see). But the code is more complicated now (with ~90 more lines) and I haven't even properly implemented the paintEvent.

yeah, it's a bit complex but is nice. many seems to have issues with that. maybe trying with a fade in/fade out, so it fakes a movement on the z axis, maybe leaving the right mouse button menu option between the movement and the fade animations (if the code of the two implementations is not too different  and if not conflicts each other)
just an idea eh :)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/278/#review278
-----------------------------------------------------------


On 2008-03-09 07:11:19, Mehdi Salem Naraghi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/278/
> -----------------------------------------------------------
> 
> (Updated 2008-03-09 07:11:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds a nice transition animation during a tabswitch . The code now uses Phase::customAnimation() instead of the former QTimeLine.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
> 
> Diff: http://mattr.info/r/278/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehdi
> 
>