Review Request: Moving of plasmoids on panel

[Stephan Binner]

> On 2008-03-10 16:10:55, Aaron Seigo wrote:
> > the moving of the applets part looks ok, but the user interaction part is not particularly smooth. it's an easy way to accomplish it, but we can do better.
> > 
> > i'll work on the panel toolbox implementation so we can do this more elegantly.
> >

Any ETA for this? Before the next Plasma backport week-end (which is when?)?


> On 2008-03-10 16:10:55, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/libs/plasma/containment.h, line 286
> > <http://mattr.info/r/261/diff/2/#file1128line286>
> >
> >     contextActions makes this unecessary; they get put right before Remove anyways, so it's all good. if anything, i suppose contextActions could take a QPoint which would allow implementation to vary the return based on what area is being click on (if that matters any).

> contextActions makes this unecessary; they get put right before Remove anyways, so it's all good.

Not good, the grouping by the separator is illogical then. "Move Applet" is more related to "Close Applet" then to a non-Applet specific "Add Widgets...".

> i suppose contextActions could take a QPoint which would allow implementation to vary the return based on what area is being click on (if that matters any).

Of course it matters, without information about applet/scenePos how shall the containment know which applet to act on (here move)?


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/261/#review285
-----------------------------------------------------------


On 2008-03-10 08:38:37, Stephan Binner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/261/
> -----------------------------------------------------------
> 
> (Updated 2008-03-10 08:38:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Simple implementation to allow rearranging of plasmoids on panels (#154119).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/261/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan
> 
>