Review Request: Moving of plasmoids on panel

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/261/#review285
-----------------------------------------------------------


the moving of the applets part looks ok, but the user interaction part is not particularly smooth. it's an easy way to accomplish it, but we can do better.

i'll work on the panel toolbox implementation so we can do this more elegantly.



trunk/KDE/kdebase/workspace/libs/plasma/containment.h
<http://mattr.info/r/261/#comment208>

    contextActions makes this unecessary; they get put right before Remove anyways, so it's all good. if anything, i suppose contextActions could take a QPoint which would allow implementation to vary the return based on what area is being click on (if that matters any).



trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
<http://mattr.info/r/261/#comment209>

    a move entry may well make sense, but then a simple click at the end should stop the move. best would be to just allow drag-and-move, really. of course, we're back to the issue we had on the desktop without handles... which is why the panel ought to have its toolbox so that it is possible to put it into an "edit" mode.


- Aaron


On 2008-03-10 08:38:37, Stephan Binner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/261/
> -----------------------------------------------------------
> 
> (Updated 2008-03-10 08:38:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Simple implementation to allow rearranging of plasmoids on panels (#154119).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/261/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephan
> 
>