Review Request: Resize device notificatior correctly

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/266/#review266
-----------------------------------------------------------


good catch. unfortunately the way this applet was being written it made it a lot more difficult than necessary to fix the problem, as can be seen in your patch.

i've fixed up the applet, which also fixed your issue nearly for free.

constraintsUpdated was the right approach, though. =)

- Aaron


On 2008-03-07 09:20:29, Beat Wolf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/266/
> -----------------------------------------------------------
> 
> (Updated 2008-03-07 09:20:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> With that patch, the device notitificator icon in the panel is resized correctly.
> The code has been mostly copy pasted from kickoff.
> This is my second patch, i don't have a svn account.
> 
> Update: even corrected a second bug, dragging the device notifier from the desktop on the panel works now.
> But the popup does not work yet when doing that. But before that patch it wasnt possible to drag the applet to the panel anyway.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp
> 
> Diff: http://mattr.info/r/266/diff
> 
> 
> Testing
> -------
> 
> Resized the panel.
> Added the applet to the desktop.
> Dragging applet to the panel from the desktop
> 
> 
> Screenshots
> -----------
> 
> before
>   http://mattr.info/r/266/s/31/
> after
>   http://mattr.info/r/266/s/32/
> 
> 
> Thanks,
> 
> Beat
> 
>