Review Request: Resize device notificatior correctly

Beat Wolf asraniel at fryx.ch
Fri Mar 7 16:20:29 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/266/
-----------------------------------------------------------

(Updated 2008-03-07 09:20:29.350386)


Review request for Plasma.


Summary
-------

With that patch, the device notitificator icon in the panel is resized correctly.
The code has been mostly copy pasted from kickoff.
This is my second patch, i don't have a svn account.

Update: even corrected a second bug, dragging the device notifier from the desktop on the panel works now.
But the popup does not work yet when doing that. But before that patch it wasnt possible to drag the applet to the panel anyway.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h
  trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp

Diff: http://mattr.info/r/266/diff


Testing
-------

Resized the panel.
Added the applet to the desktop.
Dragging applet to the panel from the desktop


Screenshots
-----------

before
  http://mattr.info/r/266/s/31/
after
  http://mattr.info/r/266/s/32/


Thanks,

Beat



More information about the Panel-devel mailing list