Review Request: disable toolbox for now

[Celeste Paul]

> On 2008-03-03 10:18:20, Aaron Seigo wrote:
> > sorry, this isn't going to happen. we've discussed this thoroughly.
> > 
> > http://bugs.kde.org/show_bug.cgi?id=154535
> > 
> > you can, of course, put this patch in your downstream builds. you'll be doing the project a disservice, however. or are we not actually developing software in the open anymore but only delivering a final product and therefore completely avoiding the entire feedback cycle? if so, show me where our new Q/A and usability labs are where we can send features for testing and review.
> > 
> > having this toolbox there has allowed us to find and fix bugs in 4.0.x. for whatever reason, people seem to think that's a bizarre goal to have. 
> > 
> > it also will grow into something that has clearer purpose. disabling it now just means more code maintenance and far less testing. i'm concerned it will also scuttle future work on it.
> > 
> > the issues with it are afaik fixable. and many of the complaints are complete BS (such as the "it interferes with closing my window!" it doesn't).
> > 
> > btw, context menus are hidden features (hello usability!) that tend to only work nicely in a two button mouse world (hello touch screens!).
> > 
> > minor issue: the patch doesn't follow the coding style.
> 
> Dirk Mueller wrote:
>     I don't want to put the patch in downstream builds for exactly the reason you gave. I'm also not opposed to finding bugs with the toolbox implementation, but thats what we have weekly KDE 4.1 builds for those people who want to try it. KDE 4.0.x however is our supposed-to-be-stable build, and for that having something enabled that only exposes bugs (tried panel over it? tried xinerama? tried zoom-out?) and not a useful feature (well, perhaps other than "Add widget") is not looking like something that is supposed to be stable. (not that it would matter here, but I've seen funny reactions at FOSDEM from people actually trying the toolbox, especially with a non-default panel). 
>     
>     
>     also, is it really supposed to appear on every xinerama screen? isn't it supposed to be just on the main screen? or on the top-right one (btw, where to configure the location?). 
>

I agree with Aaron that the toolbox should stay, but not for exactly the same reasons.  It will eventually do something, and so leaving it there will prepare users for it.  Basically it is saying "Hi!  I'm the toolbox and I hope to do more for you in the future, check back later!", but is also easy to ignore.  It would be weird for users using KDE 4.0 to have it disappear for a few months only to have it come back.

However, after reviewing some of the comments in the bug report I think there is an interest for a function to disable the menu if you don't want it -- just not by disabled by default.  Disabling the toolbox by default risks having users forget (or not learn) that this functionality exists.  Right now that might not matter because it doesn't do much, but it will in the future.  This disabling function would probably make more sense in the future when the toolbox does more; in a way it would be an ability to conceptually turn off zooming (and whatever else the toolbox controls) even if it isn't technically disabled.  

Right now as it is, it's harmless in a non-buggy crashing state.


- Celeste


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/241/#review232
-----------------------------------------------------------


On 2008-03-03 10:04:51, Dirk Mueller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/241/
> -----------------------------------------------------------
> 
> (Updated 2008-03-03 10:04:51)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch disables the toolbox by default - which up to my knowledge does not provide any useful feature other than "Add Widget" in KDE 4.0.x. "Add Widget" is however already available via the desktop context menu. It seems from the openSUSE feedback, the toolbox confuses users (especially when they shrink their wallpaper with it). 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
> 
> Diff: http://mattr.info/r/241/diff
> 
> 
> Testing
> -------
> 
> started plasma with the patch, confirmed that it does not crash
> 
> 
> Thanks,
> 
> Dirk
> 
>