KColorPicker and other plasmoids

[Pino Toscano]

Hi,

(please CC me for replies)

> Is it ok to commit ?

No, it is not ok. And the reason is *exactly* what you wrote on the review 
board:

> Perhaps we have to put this line of code directly in Plasma::PushButton to
> avoid problems with other applets ?

You are solving the problem in the wrong place; fixing kolourpicker will *not* 
fix any plasmoid using Plasma::PushButton in situation like this.

The fact that setMinimumSize() "is needed" to not make the buttons be drawn 
outside the applet (in case it is too small), smells like a Qt bug.

Oh, and am I also against the maximum 50px threshold, setting proper size 
policies should work.

Furthermore, please leave back the 4px layout margin, otherwise the button 
will be too tight.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080619/47d0883e/attachment.pgp