Patch for system tray layouting
Rafael Fernández López
ereslibre at kde.org
Sun Jun 15 00:54:21 CEST 2008
Hi,
Actually, a real patch would work. A real patch helps people who are not the
author but can give feedback by reading the rest of the code (like me) to give
a hand.
What I can tell, and is in relation to what Bernhard said is: really guys, if
we ever go mobile, we will just cry because of all those hard coded values we
will have to change. For this sizes, instead of a pretty hard coded value
(22), use, please, KIconLoader::SizeSmallMedium.
If we ever go mobile, we can do SizeSmallMedium = 11 and all our icons will be
smaller, without the need of changing hard coded values everywhere.
However, the logic of the (patch?) makes sense for me.
Next time, please, do a "svn diff", which will be much better for review,
rather than posting directly code on your message :)
Regards,
Rafael Fernández López.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080615/57a1b77e/attachment.pgp
More information about the Panel-devel
mailing list