[PATCH] Plasma::Service fixes
Aaron J. Seigo
aseigo at kde.org
Mon Jul 14 03:04:23 CEST 2008
On Sunday 13 July 2008, Alex Merry wrote:
> I've been trying to implement service support in the nowplaying engine. I
> still haven't succeeded (having trouble with moc), but this patch addresses
> various problems with Plasma::Service, including the classes not being
> exported and registerOperationScheme() never being called.
looks good, aside from:
> I also gave services created from a plugin the same name as the plugin by
> default.
in Applet we pass in the storageId by default (to make finding it again via
KService easier). i'm not convinced it's worth the extra memory usage to
allocate an object name in this case; i'd rather see it consistent with
Applet?
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080713/4cec90da/attachment.pgp
More information about the Panel-devel
mailing list