[PATCH] Webcontent scrolling

[William Viana]

I hadn't seen that function earlier, thanks. Now it seems to work very
well. Does it make sense as a private slot?
If it's ok I'll commit.
-- 
    -William-

2008/7/13 Marco Martin <notmart at gmail.com>:
> On Sunday 13 July 2008, William Viana wrote:
>> Sorry, not a QGraphicsProxyWidget but a QGraphicsWidget. Anyway, I
>> don't know how to do it.
> hmm, you shouldn't need that.
> just make a slot in Webcontent that calls update(qrect), let's say it's called
> updateRequested(qrect)
>
> and then in setPage you put a
> connect (d->page, SIGNAL( repaintRequested ( const QRect &)), this,
> SLOT(updateRequested(const qrect &)))
>
> Cheers,
> Marco MArtin
>> 2008/7/13 William Viana <vianasw at gmail.com>:
>> > mmm I'm trying to do as you say aaron but I can't figure out how to
>> > initialize the painter needed to the render function. The painter
>> > needs a QPaintDevice and I've no clue of how to do that in a
>> > QGraphicsProxyWidget. Any suggestion?
>> >
>> > 2008/7/11 Aaron J. Seigo <aseigo at kde.org>:
>> >> On Friday 11 July 2008, William Viana wrote:
>> >>> The WebContent widget was not scrolling well. I took a look and by
>> >>> adding a call to update() in some of the events it at least works
>> >>> better.  update() forces a call to paint which is probably not the
>> >>> best thing to do after every mousePressEvent but I couldn't find a
>> >>> better way. It works well when you move the scroll bar but not really
>> >>> well when you click and press the scroll bar's arrows (no idea why).
>> >>> The update() call on loadFinished makes the widget to display the
>> >>> content faster.
>> >>>
>> >>> Please review.
>> >>
>> >> makes sense, though i wonder if there isn't a way to get the needed
>> >> update area from webkit and only update those areas.
>> >>
>> >> indeed, QWebPage has the following signal:
>> >>
>> >> void repaintRequested ( const QRect & dirtyRect )
>> >>
>> >> does conneting that signal to a slot that then calls update(dirtyRect)
>> >> on the Plasma::WebContent object work even better?
>> >>
>> >> --
>> >> Aaron J. Seigo
>> >> humru othro a kohnu se
>> >> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>> >>
>> >> KDE core developer sponsored by Trolltech
>> >>
>> >>
>> >> _______________________________________________
>> >> Panel-devel mailing list
>> >> Panel-devel at kde.org
>> >> https://mail.kde.org/mailman/listinfo/panel-devel
>>
>> _______________________________________________
>> Panel-devel mailing list
>> Panel-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: webcontent.diff
Type: text/x-diff
Size: 1726 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080713/f881fc0b/attachment.bin