[PATCH] frame plasmoid: Switch photo when the user clicks on it

[Anne-Marie Mahfouf]

Le Friday 04 July 2008 14:MM:49 Éric ALBER, vous avez écrit :
> Hi,
>
> I wrote a litte patch for the frame plasmoid.
> The idea is that if you click on the photo in the frame, it switches
> immediately to the next photo in slideshow mode
>
> I have also fixed two compiler warnings (misuse of uint and a missing
> Q_UNUSED).
>
> I attached the patch to this mail. It applies to
> trunk/KDE/kdeplasmoids/applets/frame/frame.cpp
> trunk/KDE/kdeplasmoids/applets/frame/frame.h
> trunk/KDE/kdeplasmoids/applets/frame/slideshow.cpp
> I created the patch in the kdeplasmoids directory
>
> I also noticed that void mousePressEvent (QGraphicsSceneMouseEvent *event)
> and other methods are not declared virtual in Plasma/Applet but the same
> methods are virtual in QGraphicsItem. I also noticed that the destructor of
> the Applet class is not virtual either. Is this a design choice or has it
> just been forgotten ?
>
> Regards,
>
> Eric
CCing panel-devel mailing list as well - please reply to both 

OK this needs a bit more thinking. There's a bug report (wish)
http://bugs.kde.org/show_bug.cgi?id=165704
asking for a preview, pause and next action.

There are several ways to do it (in my opinion):
- mouse clicks: like the patch suggests. I am not keen on actions that the 
user cannot be aware of like clicking. If SHIFT-click makes it move backward, 
how is the user aware of that?  
- right click menu as suggested in the wish report: we'll end up with a right 
click menu with too much options, people want a Open With... and whatsnot 
action action as well.
- triangles like the Comic widget does
- on hover, integrated arrows + a pause button in the handle (the handle being 
the thing where you get the 4 icons on the left)
- other?

For next/previous and pause I'd like to hear about your use case of those (why 
do you want them, why isn't the timer enough for your needs, why you don't 
use GWenView,...) then if those are needed I'd like to hear about the several 
different ways suggested above.

Anne-Marie

PS I'll apply the warning and virtual fixes!