Review Request: shadowBlur and shadowText libplasma functions

Jamboarder jamboarder at yahoo.com
Wed Jul 2 17:26:08 CEST 2008


> From: Fredrik Höglund <fredrik at kde.org>
> 
> On Tuesday 01 July 2008 08:56, Jamboarder wrote:
> > http://reviewboard.vidsolbach.de/r/64/
> > 
> > This patch exports a shadowBlur function and add a shadowText convenience 
> function for libplasma.
> > Folderview will be patched so that the title uses the shadowText function.  
> Other areas of plasma might find this function useful as well (krunner and 
> perhaps Plasma::Icon comes to mind).
> 
> Hi Andrew,
> 
> I've looked at your patch, and I have a few comments:
> ...
> I would suggest that you change the API to something like this instead:
> 
> void drawShadowedText(QPainter *painter, const QPoint &pos,
>     const QString &text, int radius, const QColor &shadowColor,
>     const QPoint &offset)

Thanks much for the review comments Fredrik.  I'll work on your suggestions tonight.

Thanks again,
Andrew


More information about the Panel-devel mailing list