[PATCH] small applethandle cleanup

Aaron J. Seigo aseigo at kde.org
Wed Jan 23 11:19:26 CET 2008


On Wednesday 23 January 2008, Chani wrote:
> I was finding the applethandle code kinda hard to read, so I made some
> little changes that i think make it clearer. however, it means creating a

it is a readability improvement. i'm all for that.

> couple of extra variables - I'm not certain whether the clarity is worth
> whatever minor loss of efficiency this would bring.

probably no real difference in efficiency either way.

> it also fixes a tiny misalignment of the button images and their clickable
> areas - looks like two of the calculation areas got out of sync, so I've
> marked the related code.

good idea.

> I don't like the fact that the same calculations are done twice, but I'm
> not sure if it's worth doing anything about it.

probably not. marking them with a comment to be sure that they are kep tin 
sync is probably enough.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080123/4a893fda/attachment.pgp 


More information about the Panel-devel mailing list