[PATCH] small applethandle cleanup

Chani chanika at gmail.com
Wed Jan 23 10:51:05 CET 2008


I was finding the applethandle code kinda hard to read, so I made some little 
changes that i think make it clearer. however, it means creating a couple of 
extra variables - I'm not certain whether the clarity is worth whatever minor 
loss of efficiency this would bring.

it also fixes a tiny misalignment of the button images and their clickable 
areas - looks like two of the calculation areas got out of sync, so I've 
marked the related code.

I don't like the fact that the same calculations are done twice, but I'm not 
sure if it's worth doing anything about it.

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: handles2.diff
Type: text/x-diff
Size: 4105 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080123/7b4c8dfb/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080123/7b4c8dfb/attachment-0001.pgp 


More information about the Panel-devel mailing list